Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a production Sentry “UnhandledRejection” originating from the CodeMirror JSON linter’s Nunjucks template rendering step, preventing template-render failures from bubbling as unhandled promise rejections.
Changes:
- Wrap the Nunjucks
render()call (and subsequentjsonlint.parse) in a singletry/catchto avoid unhandled rejections during linting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+47
| const renderedText: string | null = await render(text, {}); | ||
| if (renderedText) { | ||
| jsonlint.parse(renderedText); | ||
| } catch {} | ||
| } | ||
| } | ||
| } catch {} |
There was a problem hiding this comment.
Catching render() rejections fixes the unhandled promise, but the empty catch also causes the validator to silently return no lint errors when template rendering fails (e.g., undefined variables, syntax errors, or getNunjucks failures). That means invalid JSON can appear “valid” to the linter.
Consider falling back to linting the original text when rendering fails (still wrapped so it can’t throw), and/or call render with ignoreUndefinedEnvVariable: true to avoid rejecting for missing variables during linting.
✅ Circular References ReportGenerated at: 2026-04-08T09:01:42.947Z Summary
Click to view all circular references in PR (62)Click to view all circular references in base branch (62)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
ZxBing0066
approved these changes
Apr 8, 2026
CurryYangxx
force-pushed
the
fix/template-render-error
branch
from
ad19cb3 to
62eb398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve this sentry error:
https://konghq.sentry.io/issues/7310821007/?environment=production&project=6311804&query=is%3Aunresolved&referrer=issue-stream&sort=freq