Add board_introduced field to reusable boards and JSON output#272
Add board_introduced field to reusable boards and JSON output#272igorpecovnik wants to merge 2 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds a new Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
release-targets/reusable.yml (1)
198-207:⚠️ Potential issue | 🟡 MinorPotential inconsistency: slug says CM3 but name and year suggest CM1.
The
board_slugisraspberrypicm3butboard_nameis "Raspberry Pi CM" andboard_introducedis "2014". The original Compute Module (CM1) was released in 2014, while the Compute Module 3 (CM3) was released in 2017.Please verify whether this entry represents CM1 (2014) or CM3 (2017) and align the slug, name, and year accordingly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@release-targets/reusable.yml` around lines 198 - 207, The entry is inconsistent: board_slug "raspberrypicm3" conflicts with board_name "Raspberry Pi CM" and board_introduced "2014" (CM1); verify which compute module this row represents and make fields consistent — if it represents the original Compute Module (CM1) change board_slug to something like "raspberrypicm" or "raspberrypicm1" and update uses/branch/file_extension if needed; if it represents Compute Module 3 (CM3) update board_name to "Raspberry Pi Compute Module 3" and board_introduced to "2017" (and adjust board_slug to "raspberrypicm3") so that board_slug, board_name, and board_introduced match.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@release-targets/reusable.yml`:
- Around line 35-36: The JSON generator script generate-armbian-images-json.sh
is ignoring the new board_introduced field; update the shell read and Python
print to propagate it: add a new variable (e.g., introduced) to the shell read
invocation that currently reads "slug name vendor support uses branch ext",
ensure any associative array storage used for board metadata also stores
introduced if arrays like board_name/board_vendor exist, and include the new
introduced variable in the Python print() call that emits the seven fields so
the output emits board_introduced as well; modify any downstream consumers to
reference the new associative key if needed.
---
Outside diff comments:
In `@release-targets/reusable.yml`:
- Around line 198-207: The entry is inconsistent: board_slug "raspberrypicm3"
conflicts with board_name "Raspberry Pi CM" and board_introduced "2014" (CM1);
verify which compute module this row represents and make fields consistent — if
it represents the original Compute Module (CM1) change board_slug to something
like "raspberrypicm" or "raspberrypicm1" and update uses/branch/file_extension
if needed; if it represents Compute Module 3 (CM3) update board_name to
"Raspberry Pi Compute Module 3" and board_introduced to "2017" (and adjust
board_slug to "raspberrypicm3") so that board_slug, board_name, and
board_introduced match.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 42e20f77-5460-43e4-bdaf-b634ea0c5f10
📒 Files selected for processing (1)
release-targets/reusable.yml
Extract INTRODUCED from board configs and board_introduced from reusable.yml, and include it in the JSON output for each board.
Summary
board_introducedyear field to all 15 reusable board entries inreusable.ymlgenerate-armbian-images-json.shto extractINTRODUCEDfrom board configs andboard_introducedfrom reusable.yml, and include it in the JSON outputTest plan
board_introducedfor base and reusable boards