-
Notifications
You must be signed in to change notification settings - Fork 341
fix: compile with actionlint/zizmor/poutine no longer marks valid workflows as invalid when Docker is unavailable #25251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -130,20 +130,38 @@ Returns JSON array with validation results for each workflow: | |||||||||||||||
| default: | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| // dockerUnavailableWarning is set when Docker is not accessible but the compile | ||||||||||||||||
| // should still proceed without the static-analysis tools. After a successful | ||||||||||||||||
| // compile the warning is appended to every workflow result so the caller | ||||||||||||||||
| // knows linting was skipped — without marking valid workflows as invalid. | ||||||||||||||||
|
||||||||||||||||
| // should still proceed without the static-analysis tools. After a successful | |
| // compile the warning is appended to every workflow result so the caller | |
| // knows linting was skipped — without marking valid workflows as invalid. | |
| // should still proceed without the static-analysis tools. After the compile | |
| // attempt, the warning is appended to workflow results in the JSON output so | |
| // the caller knows linting was skipped, while preserving each workflow's | |
| // valid/invalid status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
injectDockerUnavailableWarningtests are added here indocker_images_test.go, but the helper being tested lives inmcp_tools_readonly.go. For consistency with the existing file-per-feature test layout (e.g.,actionlint.go/actionlint_test.go,flags.go/flags_test.go), consider moving these tests into a newmcp_tools_readonly_test.go(or similar) to keep related tests discoverable.