fix: escape HTML special characters in build.sh to prevent HTML injection#1222
Open
pranitaurlam wants to merge 1 commit intographql:mainfrom
Open
fix: escape HTML special characters in build.sh to prevent HTML injection#1222pranitaurlam wants to merge 1 commit intographql:mainfrom
pranitaurlam wants to merge 1 commit intographql:mainfrom
Conversation
…tion Add html_escape() function to sanitize git tag names, tag titles, and commit dates before interpolating them into public/index.html. Also fix unquoted echo to prevent word splitting. Closes graphql#1220 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
html_escape()function to sanitize&,<,>, and"characters before interpolating git-derived data intopublic/index.html$GITTAG,$TAGTITLE, and$GITDATEused in HTML table rowsecho $HTML→echo "$HTML"to prevent word splittingCloses #1220 in graphql/graphql-spec
Test plan
build.shruns successfully on current repo<script>would be escaped to<script>in the output HTML&would be rendered as&in the output HTML🤖 Generated with Claude Code