Skip to content

[WIP] add CPU request validation in NRI CreateContainer hook#110

Open
AutuSnow wants to merge 1 commit intokubernetes-sigs:mainfrom
AutuSnow:feat/add_req_validation
Open

[WIP] add CPU request validation in NRI CreateContainer hook#110
AutuSnow wants to merge 1 commit intokubernetes-sigs:mainfrom
AutuSnow:feat/add_req_validation

Conversation

@AutuSnow
Copy link
Copy Markdown
Contributor

@AutuSnow AutuSnow commented Apr 6, 2026

Validation rules:

  1. If container CPU request is specified, it must exactly match claim allocation
  2. Pod-level resources validation (PLR) is a placeholder for future implementation

fixs:#108

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AutuSnow
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 6, 2026
@AutuSnow AutuSnow changed the title add CPU request validation in NRI CreateContainer hook [WIP] add CPU request validation in NRI CreateContainer hook Apr 6, 2026
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2026
@AutuSnow AutuSnow force-pushed the feat/add_req_validation branch from da1d1b1 to 498fb24 Compare April 8, 2026 14:48
Signed-off-by: qiuxue <liuyutao36@gmail.com>
@AutuSnow AutuSnow force-pushed the feat/add_req_validation branch from 498fb24 to 40c13e9 Compare April 8, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants