Skip to content

Filter out unschedulable nodes in kubectl describe e2e test#138259

Open
xueqzhan wants to merge 1 commit intokubernetes:masterfrom
xueqzhan:fix-kubectl-describe-race
Open

Filter out unschedulable nodes in kubectl describe e2e test#138259
xueqzhan wants to merge 1 commit intokubernetes:masterfrom
xueqzhan:fix-kubectl-describe-race

Conversation

@xueqzhan
Copy link
Copy Markdown
Contributor

@xueqzhan xueqzhan commented Apr 7, 2026

What type of PR is this?

/kind flake

What this PR does / why we need it:

Fix race condition where the kubectl describe conformance test picks up an ephemeral fake node created by the parallel node lifecycle test (test/e2e/node/node_lifecycle.go), which gets deleted before the describe command runs, causing a NotFound error.

Here is a link to an openshift CI job that failed this test.

Which issue(s) this PR is related to:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

No

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@xueqzhan
Filter out unschedulable nodes in kubectl describe e2e test
44d3a49 
Fix race condition where the kubectl describe conformance test picks up
an ephemeral fake node created by the parallel node lifecycle test
(test/e2e/node/node_lifecycle.go), which gets deleted before the
describe command runs, causing a NotFound error.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 7, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2026

Hi @xueqzhan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 7, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 7, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Apr 7, 2026
@xueqzhan
Copy link
Copy Markdown
Contributor Author

xueqzhan commented Apr 7, 2026

/cc @ardaguclu

@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Apr 7, 2026

/release-note none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2026
@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Apr 7, 2026

/release-note-none
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 7, 2026
@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Apr 8, 2026

/retest

@soltysh soltysh moved this from Needs Triage to In Progress in SIG CLI Apr 8, 2026
@soltysh soltysh moved this from In Progress to Needs Review in SIG CLI Apr 8, 2026
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Apr 8, 2026

/assign @ardaguclu

@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Apr 8, 2026 •
edited
Loading

This is complementary to #135476. Fake-node causes issues in this test as well
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 8, 2026

LGTM label has been added.

DetailsGit tree hash: 82e5f955d3e35b7433b7228c4ca7c80e2f128794

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@ardaguclu ardaguclu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG CLI
Status: Needs Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xueqzhan @k8s-ci-robot @ardaguclu @soltysh