Skip to content

Upgrade React 18+ support and replace sortable tree patch #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Upgrade React 18+ support and replace sortable tree patch #10

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
399fdea
Initial plan
Copilot Jan 20, 2026
9b924f7
chore: upgrade React 18 deps
Copilot Jan 20, 2026
a87155f
docs: note React 18 requirement
Copilot Jan 20, 2026
a1e99d9
docs: clarify React 18 requirement
Copilot Jan 20, 2026
a7b4b18
chore: allow React 19 peers
Copilot Jan 20, 2026
c5fd30d
Changes before error encountered
Copilot Jan 20, 2026
5d66c40
fix: transpile MUI optional chaining in dev
Copilot Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ MUI-Datatables is a responsive datatables component built on [Material-UI](https

`npm install mui-datatables --save`

React 18+ is required (both `react` and `react-dom`). This is a breaking change for projects still on React 16 or 17.

If your project doesn't already use them, you need to install MUI v7 and its icon pack:
`npm --save install @mui/material @emotion/react @emotion/styled @mui/icons-material`

Expand Down
160 changes: 43 additions & 117 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,12 @@
"@emotion/react": "^11.14.0",
"@mui/icons-material": "^7.3.7",
"@mui/material": "^7.3.7",
"react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0",
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0"
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"dependencies": {
"@babel/runtime-corejs3": "^7.12.1",
"@dnd-kit/core": "^6.3.1",
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @dnd-kit/core dependency has been added but is not used anywhere in the codebase. The existing drag-and-drop functionality uses react-dnd and react-dnd-html5-backend (which remain in dependencies). If the intention was to replace react-dnd with @dnd-kit/core, the implementation is incomplete. If @dnd-kit/core is not needed, it should be removed to avoid unnecessary dependencies.

Suggested change
"@dnd-kit/core": "^6.3.1",

Copilot uses AI. Check for mistakes.
"@emotion/cache": "^11.7.1",
"tss-react": "^4.9.20",
"clsx": "^1.1.1",
Expand All @@ -121,7 +122,6 @@
"prop-types": "^15.7.2",
"react-dnd": "^11.1.3",
"react-dnd-html5-backend": "^11.1.3",
"react-sortable-tree-patch-react-17": "^2.9.0",
"react-to-print": "^2.8.0"
},
"overrides": {
Expand Down
Loading