websocket: pass failure cause through to error event#4996
Open
chrmarti wants to merge 1 commit intonodejs:mainfrom
Open
websocket: pass failure cause through to error event#4996chrmarti wants to merge 1 commit intonodejs:mainfrom
chrmarti wants to merge 1 commit intonodejs:mainfrom
Conversation
The cause parameter in failWebsocketConnection was not being passed
through to onSocketClose, resulting in the TypeError fired in the
error event missing its cause property (e.g., the ECONNREFUSED error).
Pass the cause as an argument through onSocketClose to #onSocketClose
so that the TypeError is created with { cause } when available.
Fixes: nodejs#4991
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cause parameter in failWebsocketConnection was not being passed
through to onSocketClose, resulting in the TypeError fired in the
error event missing its cause property (e.g., the ECONNREFUSED error).
Pass the cause as an argument through onSocketClose to #onSocketClose
so that the TypeError is created with { cause } when available.
Fixes #4991