test: remove abort-controller shim dependency#4997
Open
trivikr wants to merge 2 commits intonodejs:mainfrom
Open
test: remove abort-controller shim dependency#4997trivikr wants to merge 2 commits intonodejs:mainfrom
trivikr wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4997 +/- ##
==========================================
+ Coverage 92.92% 92.93% +0.01%
==========================================
Files 110 110
Lines 35729 35729
==========================================
+ Hits 33201 33205 +4
+ Misses 2528 2524 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Not sure why It probably needs a retry, if maintainers think this change is useful. |
KhafraDev
requested changes
Apr 8, 2026
Member
KhafraDev
left a comment
KhafraDev
left a comment
There was a problem hiding this comment.
the point of the test is to support third party abortcontroller/abortsignal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
AbortController being stable in node v15.4.0: https://nodejs.org/api/globals.html#class-abortcontroller
Rationale
undicinow requires Node.js>=22.19.0, so theabort-controllerdevDependency is no longer needed.The test coverage can use the native
AbortControllerdirectly.Changes
abort-controllerfromdevDependenciesAbortControllerDOMExceptionreasonFeatures
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status
Signed-off-by: Kamat, Trivikram 16024985+trivikr@users.noreply.github.com