OPL/Columnar Query Engine Support some TextExpression variants#2586
Open
albertlockett wants to merge 10 commits intoopen-telemetry:mainfrom
Open
OPL/Columnar Query Engine Support some TextExpression variants#2586albertlockett wants to merge 10 commits intoopen-telemetry:mainfrom
TextExpression variants#2586albertlockett wants to merge 10 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
+ Coverage 88.35% 88.47% +0.11%
==========================================
Files 613 618 +5
Lines 222680 226631 +3951
==========================================
+ Hits 196752 200502 +3750
- Misses 25404 25605 +201
Partials 524 524
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
OPL / Columnar Query Engine support the
Concat,JoinandReplacevariants of theTextExpression. In all these cases, we parse from specially named functions:In each of these cases, we use the equivalent datafusion scalar function
concat,concat_ws(for join) andreplace.Note:
concat_wsis also used as an alias forjoin. I was thinking this'd be helpful for folks coming from a datafusion/SQL background. So it's equally possibly to write an expression like:In
planner.rs, I refactored the planning of function arguments into a reusable helper function.What issue does this PR close?
TextScalarExpression#2578How are these changes tested?
Unit
Are there any user-facing changes?
These new expression types are now supported via the transform processor.
Future work
Will add support for the
TextExpression::Capturevariant of this expression in future PR.